-
Notifications
You must be signed in to change notification settings - Fork 170
[#1664] improvement(docs): Update the descriptions and default values of outdated conf #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 2 362 files + 62 2 362 suites +62 4h 24m 28s ⏱️ + 23m 10s For more details on these errors, see this check. Results for commit 1f77cc1. ± Comparison against base commit 45ad0b8. ♻️ This comment has been updated with latest results. |
|
Did you verify these parameters in your production environment? |
I don't get your point. I've just changed the docs in this PR. I think it does not need any tests. |
You seems to change some default values. Did you use these default values in your production environment? |
I did not change any default values. You can check again. I just update the docs for the configs whose default values are outdated. |
| XMX_SIZE=80g | ||
| MAX_DIRECT_MEMORY_SIZE=60g | ||
| XMX_SIZE=20g | ||
| MAX_DIRECT_MEMORY_SIZE=120g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to modify this value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a doc about configs when using Netty. And it is more reasonable because we don't use that much heap memory anymore when enabling Netty. I've tested this (20g) already. It works perfectly. Even maybe 10g of heap memory is enough too(I will test this later).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I got it.
What changes were proposed in this pull request?
Update the descriptions and default values of some configurations.
Why are the changes needed?
Fix: #1664.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unnecessary.