Skip to content

Conversation

@rickyma
Copy link
Contributor

@rickyma rickyma commented Apr 19, 2024

What changes were proposed in this pull request?

Update the descriptions and default values of some configurations.

Why are the changes needed?

Fix: #1664.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unnecessary.

@github-actions
Copy link

github-actions bot commented Apr 19, 2024

Test Results

 2 362 files  + 62   2 362 suites  +62   4h 24m 28s ⏱️ + 23m 10s
   919 tests ±  0     917 ✅ ±  0   1 💤 ±0  0 ❌ ±0  1 🔥 ±0 
10 615 runs  +120  10 600 ✅ +122  14 💤 ±0  0 ❌ ±0  1 🔥  - 2 

For more details on these errors, see this check.

Results for commit 1f77cc1. ± Comparison against base commit 45ad0b8.

♻️ This comment has been updated with latest results.

@rickyma rickyma changed the title [#1664] docs: Update the descriptions and default values of some configurations [#1664] docs: Update the descriptions and default values of outdated configurations Apr 19, 2024
@roryqi
Copy link
Contributor

roryqi commented Apr 19, 2024

Did you verify these parameters in your production environment?

@rickyma
Copy link
Contributor Author

rickyma commented Apr 19, 2024

Did you verify these parameters in your production environment?

I don't get your point. I've just changed the docs in this PR. I think it does not need any tests.

@roryqi
Copy link
Contributor

roryqi commented Apr 20, 2024

Did you verify these parameters in your production environment?

I don't get your point. I've just changed the docs in this PR. I think it does not need any tests.

You seems to change some default values. Did you use these default values in your production environment?

@rickyma
Copy link
Contributor Author

rickyma commented Apr 20, 2024

Did you verify these parameters in your production environment?

I don't get your point. I've just changed the docs in this PR. I think it does not need any tests.

You seems to change some default values. Did you use these default values in your production environment?

I did not change any default values. You can check again. I just update the docs for the configs whose default values are outdated.

XMX_SIZE=80g
MAX_DIRECT_MEMORY_SIZE=60g
XMX_SIZE=20g
MAX_DIRECT_MEMORY_SIZE=120g
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to modify this value.

Copy link
Contributor Author

@rickyma rickyma Apr 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a doc about configs when using Netty. And it is more reasonable because we don't use that much heap memory anymore when enabling Netty. I've tested this (20g) already. It works perfectly. Even maybe 10g of heap memory is enough too(I will test this later).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I got it.

@rickyma rickyma requested a review from roryqi April 23, 2024 13:12
@zuston zuston changed the title [#1664] docs: Update the descriptions and default values of outdated configurations [#1664] improvement(docs): Update the descriptions and default values of outdated conf Apr 25, 2024
@zuston zuston merged commit 1516a53 into apache:master Apr 25, 2024
@rickyma rickyma deleted the issue-1664 branch May 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Update the descriptions and default values of outdated configurations

3 participants