Skip to content

[#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zuston merged 1 commit into from
May 15, 2024
Merged

[#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts #1696

zuston merged 1 commit into from
May 15, 2024

Conversation

@rickyma
Copy link
Contributor

@rickyma rickyma commented May 11, 2024

What changes were proposed in this pull request?

Fix some flaky tests which may cause port conflicts sometimes.

Why are the changes needed?

Fix: #1675.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unnecessary.

@rickyma rickyma closed this May 11, 2024
@rickyma rickyma reopened this May 11, 2024
@github-actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

Test Results

 2 391 files  ±0   2 391 suites  ±0   4h 56m 6s ⏱️ -44s
   928 tests ±0     927 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 754 runs  ±0  10 740 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit a0052fc. ± Comparison against base commit 8e26a34.

♻️ This comment has been updated with latest results.

@rickyma
Copy link
Contributor Author

rickyma commented May 14, 2024

This could be merged. Minor fixes. More stable for the test. It forgot to stop the server, which might cause port conflicts. @zuston @jerqi

@zuston
Copy link
Member

zuston commented May 14, 2024

LGTM. Please update the PR title to describe what's this PR changed rather than coarse grained desp.

@rickyma rickyma changed the title [#1675][FOLLOWUP] fix(test): Fix flaky tests [#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts May 14, 2024
@jerqi
Copy link
Contributor

jerqi commented May 14, 2024

Maybe we should commit this to branch 0.9, too.

@zuston zuston merged commit 4f4f7e3 into apache:master May 15, 2024
zuston pushed a commit that referenced this pull request May 15, 2024
@rickyma @zuston
[#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port con…
ab7d0dc 
…flicts (#1696)

### What changes were proposed in this pull request?

Fix some flaky tests which may cause port conflicts sometimes.

### Why are the changes needed?

Fix: #1675.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unnecessary.
@zuston
Copy link
Member

zuston commented May 15, 2024

Maybe we should commit this to branch 0.9, too.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zuston zuston zuston approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Flaky Test] Tests may fail on different machines

3 participants

@rickyma @zuston @jerqi