Skip to content

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 4, 2022

What changes were proposed in this pull request?

Enable codecov report in CI. The service is also used by Apache Spark.

Why are the changes needed?

To measure code coverage and improve the tests.

Does this PR introduce any user-facing change?

No

How was this patch tested?

The codecov report aggregated when running CI on current master:
https://codecov.io/gh/kaijchen/incubator-uniffle/tree/d3372ff61cdd9701082b72e130b4e2b7bc4fe764

@kaijchen
Copy link
Member Author

kaijchen commented Jul 4, 2022

The codecov report from this PR:
https://codecov.io/gh/apache/incubator-uniffle/tree/d3372ff61cdd9701082b72e130b4e2b7bc4fe764

We don't need extra steps to enable codecov.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@jerqi jerqi merged commit eb15611 into apache:master Jul 4, 2022
@kaijchen kaijchen deleted the codecov branch July 4, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants