[#1698][FOLLOWUP] fix(test): Increase stability of tests #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyma
force-pushed
the
issue-1698-followup
branch
2 times, most recently
from
f8f288e to
46ed754
Compare
rickyma
force-pushed
the
issue-1698-followup
branch
from
46ed754 to
002f9c2
Compare
Contributor
Author
|
@zuston @jerqi PTAL. |
zuston
approved these changes
May 28, 2024
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 2, 2024
… tests (#1739) ### What changes were proposed in this pull request? We adjust the memory arguments refer to Spark's [pom.xml](https://github.com/apache/spark/blob/master/pom.xml): > -ea -Xmx4g -Xss4m -XX:MaxMetaspaceSize=2g -XX:ReservedCodeCacheSize=${CodeCacheSize} ${extraJavaTestArgs} and [make-distribution.sh](https://github.com/apache/spark/blob/master/dev/make-distribution.sh): > export MAVEN_OPTS="${MAVEN_OPTS:--Xss128m -Xmx4g -XX:ReservedCodeCacheSize=128m}" This is more reasonable. ### Why are the changes needed? Fix: #1698. After #1726, I found that the issue may still exist. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We adjust the memory arguments refer to Spark's pom.xml:
and make-distribution.sh:
This is more reasonable.
Why are the changes needed?
Fix: #1698.
After #1726, I found that the issue may still exist.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unnecessary.