Skip to content

Conversation

@zuston
Copy link
Member

@zuston zuston commented May 24, 2024

What changes were proposed in this pull request?

Refactor the reconfigurable conf for coordinator side.

Why are the changes needed?

Follow up: #1711

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit tests

@zuston zuston requested a review from jerqi May 24, 2024 02:54
@github-actions
Copy link

github-actions bot commented May 24, 2024

Test Results

 2 433 files  +14   2 433 suites  +14   4h 59m 42s ⏱️ + 1m 49s
   933 tests ± 0     932 ✅ ± 0   1 💤 ±0  0 ❌ ±0 
10 819 runs  ± 0  10 805 ✅ ± 0  14 💤 ±0  0 ❌ ±0 

Results for commit 59ef0f8. ± Comparison against base commit a0e88da.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
org.apache.uniffle.test.CoordinatorAssignmentTest ‑ testReconfigureNodeMax
org.apache.uniffle.test.CoordinatorReconfigureNodeMaxTest ‑ testReconfigureNodeMax

♻️ This comment has been updated with latest results.

jerqi
jerqi previously approved these changes May 28, 2024
@zuston
Copy link
Member Author

zuston commented May 29, 2024

gentle ping @jerqi

@zuston zuston merged commit a3a49f0 into apache:master May 29, 2024
zuston added a commit to zuston/incubator-uniffle that referenced this pull request Jun 3, 2024
…e conf (apache#1741)

Refactor the reconfigurable conf for coordinator side.

Follow up: apache#1711

No.

Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants