[Followup] Use asList method in some existing configOptions #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Jul 4, 2022
| .stringType() | ||
| .asList() | ||
| .noDefaultValue() | ||
| .withDescription("List config key5"); |
Contributor
There was a problem hiding this comment.
If we don't set this option and call method conf.get(emptyListStringOption) directly, what will the result be?
Contributor
There was a problem hiding this comment.
Is the same behavior as Flink?
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
- Coverage 56.27% 55.43% -0.84%
+ Complexity 1168 1095 -73
============================================
Files 152 143 -9
Lines 8397 8034 -363
Branches 812 784 -28
============================================
- Hits 4725 4454 -271
+ Misses 3408 3324 -84
+ Partials 264 256 -8
Continue to review full report at Codecov.
|
Merged
jerqi
pushed a commit
that referenced
this pull request
Jul 5, 2022
### What changes were proposed in this pull request? Remove redundant package. Introduced in #18. ### Why are the changes needed? better code ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use asList method in some existing configOptions
Why are the changes needed?
Directly use the asList method in ConfigOptions to get the config list values, and then avoid splitting values by users.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UTs.