[MINOR] Improvement(dashboard): Support display human-readable time format for app page #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat for app page
Contributor
|
Good catch! Please remove useless auto-generated information in the description of this PR. Also, you can attach the picture in the comment of this PR. Don't attach it into the description, because the description will be committed as git commit message. So the picture will not be displayed. |
xianjingfeng
reviewed
Jul 2, 2024
xianjingfeng
reviewed
Jul 2, 2024
Co-authored-by: xianjingfeng <xianjingfeng666@gmail.com>
Co-authored-by: xianjingfeng <xianjingfeng666@gmail.com>
Member
Author
|
@xianjingfeng Thanks for you suggestion commit, I've accepted all of them, PTAL. |
Contributor
|
@xianjingfeng Please approve it. |
Contributor
|
@maobaolong Please delete the auto-generated info like |
Member
Author
|
@rickyma Done. |
xianjingfeng
approved these changes
Jul 3, 2024
maobaolong
added a commit
to maobaolong/incubator-uniffle
that referenced
this pull request
Aug 3, 2024
…ormat for app page (apache#1851) Display the human-readable time format in application page. A long type timestamp really hard to get information from it. Format the update time to human-readable. Manual testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Display the human-readable time format in application page.
Why are the changes needed?
A long type timestamp really hard to get information from it.
Does this PR introduce any user-facing change?
Format the update time to human-readable.
How was this patch tested?