[MINOR] improvement(client): Rename rss.shade.packageName from org.apache.uniffle to org.apache.uniffle.shaded #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyma
changed the title
Contributor
|
Merged to master. Thanks @maobaolong |
rickyma
changed the title
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 9, 2024
…ache.uniffle to org.apache.uniffle.shaded (#1883) ### What changes were proposed in this pull request? Change the default value of `rss.shade.packageName` from `org.apache.uniffle` to `org.apache.uniffle.shaded`. ### Why are the changes needed? Without this change, we cannot distinguish a class is relocated to `org.apache.uniffle.xxx` or named `org.apache.uniffle.xxx` originally. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the default value of
rss.shade.packageNamefromorg.apache.uniffletoorg.apache.uniffle.shaded.Why are the changes needed?
Without this change, we cannot distinguish a class is relocated to
org.apache.uniffle.xxxor namedorg.apache.uniffle.xxxoriginally.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not needed.