[MINOR] fix(docker): replace netcat to netcat-openbsd in Dockerfile #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianjingfeng
changed the title
advancedxy
reviewed
Jul 24, 2024
advancedxy
approved these changes
Jul 24, 2024
Contributor
advancedxy
left a comment
advancedxy
left a comment
There was a problem hiding this comment.
LGTM, it seems like this is causing other PRs' CI failing. I think we should fix it asap.
Contributor
|
I think I will merge this to unblock the docker image build process. Feel free to add file follow-up PRs to address others' comments if any. |
xianjingfeng
added a commit
to xianjingfeng/uniffle
that referenced
this pull request
Jul 25, 2024
replace netcat to netcat-openbsd in Dockerfile (apache#1950)
xianjingfeng
added a commit
that referenced
this pull request
Aug 9, 2024
### What changes were proposed in this pull request? Replace netcat to netcat-openbsd in Dockerfile. ### Why are the changes needed? On Debian, netcat isn’t a package, as two “variations” of netcat exist in the package repository. https://github.com/apache/incubator-uniffle/actions/runs/10073085326/job/27848719086?pr=1948 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI (cherry picked from commit 5ddcc28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace netcat to netcat-openbsd in Dockerfile.
Why are the changes needed?
On Debian, netcat isn’t a package, as two “variations” of netcat exist in the package repository.
https://github.com/apache/incubator-uniffle/actions/runs/10073085326/job/27848719086?pr=1948
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI