Skip to content

[#1982] fix(build): specify maven.compiler.release while JDK version greater than 8 #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
advancedxy merged 4 commits into from
Aug 9, 2024
Merged

[#1982] fix(build): specify maven.compiler.release while JDK version greater than 8 #1983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1654d1
specify maven.compiler.release in your pom.xml
xianjingfeng Jul 30, 2024
b3b7d91
specify maven.compiler.release in mvnw
xianjingfeng Jul 30, 2024
c4d15c7
nit
xianjingfeng Aug 7, 2024
6f5c6c9
add docs
xianjingfeng Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ Build with dashboard

./mvnw -DskipTests clean package -Pdashboard

> note: currently Uniffle build the project against Java 8. If you want to compile it against other Java versions, you can build the code with `-Dmaven.compiler.release=${release-version}`.

To package the Uniffle, run:

./build_distribution.sh
Expand Down
10 changes: 10 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,16 @@
</reporting>

<profiles>
<profile>
<id>set-compiler-release</id>
<activation>
<jdk>[9,)</jdk>
</activation>
<properties>
<maven.compiler.release>8</maven.compiler.release>
Copy link
Contributor

@advancedxy advancedxy Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if users want to build Uniffle with higher JDK and release with higher jdk versions?
Is it possible for them to run mvn with something like below?

./mvnw -Dmaven.compiler.release=11

If so, you should update the README.md about the Building Uniffle section as well?

Copy link
Contributor

@advancedxy advancedxy Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I tested this PR locally, it works as expected.

Copy link
Member Author

@xianjingfeng xianjingfeng Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

</properties>
</profile>

<profile>
<id>dashboard</id>
<modules>
Expand Down