Skip to content

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 4, 2022

What changes were proposed in this pull request?

Add CI and Codecov badges in README.

Why are the changes needed?

It's easier to see the CI and Codecov result.
And you can click the badges for details.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

See: https://github.com/kaijchen/incubator-uniffle/blob/badges/README.md

@codecov-commenter
Copy link

Codecov Report

Merging #20 (79a6cc6) into master (eb15611) will decrease coverage by 0.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     56.27%   55.37%   -0.90%     
+ Complexity     1168     1097      -71     
============================================
  Files           152      143       -9     
  Lines          8397     8030     -367     
  Branches        812      783      -29     
============================================
- Hits           4725     4447     -278     
+ Misses         3408     3329      -79     
+ Partials        264      254      -10     
Impacted Files Coverage Δ
...er/impl/UploadedStorageHdfsShuffleReadHandler.java 76.31% <0.00%> (-5.27%) ⬇️
.../java/org/apache/uniffle/server/ShuffleServer.java 68.14% <0.00%> (-4.43%) ⬇️
...e/uniffle/server/storage/SingleStorageManager.java 65.57% <0.00%> (-1.64%) ⬇️
...e/spark/shuffle/reader/RssShuffleDataIterator.java
.../org/apache/spark/shuffle/writer/WriterBuffer.java
...che/spark/shuffle/writer/BufferManagerOptions.java
...ava/org/apache/spark/shuffle/RssShuffleHandle.java
...org/apache/spark/shuffle/writer/AddBlockEvent.java
...k/shuffle/writer/WrappedByteArrayOutputStream.java
...org/apache/spark/shuffle/RssSparkShuffleUtils.java
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb15611...79a6cc6. Read the comment docs.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 9de136d into apache:master Jul 5, 2022
@kaijchen kaijchen deleted the badges branch July 5, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants