[ISSUE-48][FEATURE][FOLLOW UP] Add controller component#214
Merged
roryqi merged 2 commits intoapache:masterfrom Sep 20, 2022
Merged
[ISSUE-48][FEATURE][FOLLOW UP] Add controller component#214roryqi merged 2 commits intoapache:masterfrom
roryqi merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@czy006 @zuston @thousandhu Could you help me review this patch? |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
============================================
+ Coverage 58.48% 59.12% +0.63%
- Complexity 1277 1326 +49
============================================
Files 158 160 +2
Lines 8463 8725 +262
Branches 785 816 +31
============================================
+ Hits 4950 5159 +209
- Misses 3259 3301 +42
- Partials 254 265 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wangao1236
force-pushed
the
feat-open-source
branch
from
08a002c to
30ecd9e
Compare
roryqi
reviewed
Sep 14, 2022
deploy/kubernetes/operator/pkg/controller/constants/constants.go
Outdated
Show resolved
Hide resolved
wangao1236
force-pushed
the
feat-open-source
branch
from
30ecd9e to
126f893
Compare
Contributor
|
Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok? |
thousandhu
reviewed
Sep 19, 2022
wangao1236
force-pushed
the
feat-open-source
branch
from
126f893 to
a3a3cc2
Compare
roryqi
approved these changes
Sep 20, 2022
Contributor
roryqi
left a comment
roryqi
left a comment
There was a problem hiding this comment.
LGTM, thanks @wangao1236 @thousandhu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For issue #48
I add some codes about controller module, and I'll add more unit tests in next PR.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?