[#2362] feat(client): Log more compression infos #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jerqi |
jerqi
reviewed
Feb 11, 2025
| + "], compressTime[" | ||
| + compressTime | ||
| + "], compressRatio[" | ||
| + (float) uncompressedDataLen / compressedDataLen |
Contributor
There was a problem hiding this comment.
compressDataLen may be 0 zero?
jerqi
approved these changes
Feb 11, 2025
zuston
changed the title
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Feb 11, 2025
### What changes were proposed in this pull request? Followup to log more compression infos like data len and compression ratio ### Why are the changes needed? followup apache#2362 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Needn't --------- Co-authored-by: Junfan Zhang <zhangjunfan@qiyi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup to log more compression infos like data len and compression ratio
Why are the changes needed?
followup #2362
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Needn't