Skip to content

Conversation

@cchung100m
Copy link
Collaborator

@cchung100m cchung100m commented Feb 18, 2025

What changes were proposed in this pull request?

Fix the warning: [unchecked] unchecked call to add(E) as a member of the raw type List

Why are the changes needed?

Fix: #2370

Does this PR introduce any user-facing change?

No.

How was this patch tested?

image

@cchung100m cchung100m self-assigned this Feb 18, 2025
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

Test Results

 2 996 files  + 6   2 996 suites  +6   6h 37m 31s ⏱️ + 18m 33s
 1 105 tests ± 0   1 103 ✅ + 1   2 💤 ±0  0 ❌  - 1 
13 849 runs  +12  13 819 ✅ +13  30 💤 ±0  0 ❌  - 1 

Results for commit 924b3ff. ± Comparison against base commit ea3ec58.

♻️ This comment has been updated with latest results.

@cchung100m cchung100m force-pushed the issue-2370 branch 5 times, most recently from a69b9d7 to 95a0756 Compare February 19, 2025 14:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.44%. Comparing base (81e00be) to head (95a0756).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2371      +/-   ##
============================================
+ Coverage     44.18%   51.44%   +7.26%     
- Complexity        0     3026    +3026     
============================================
  Files            21      478     +457     
  Lines          2553    23085   +20532     
  Branches          0     2129    +2129     
============================================
+ Hits           1128    11877   +10749     
- Misses         1352    10463    +9111     
- Partials         73      745     +672     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cchung100m cchung100m force-pushed the issue-2370 branch 2 times, most recently from ff5c8d6 to f95c9b1 Compare February 22, 2025 06:05
@cchung100m
Copy link
Collaborator Author

Hi @jerqi @zuston

We cannot install the native libs when running github action, can you help to solve it, thanks.

image

@jerqi
Copy link
Contributor

jerqi commented Feb 24, 2025

Hi @jerqi @zuston

We cannot install the native libs when running github action, can you help to solve it, thanks.

image

We can ignore them, let @zuston to check this.

@zuston
Copy link
Member

zuston commented Feb 24, 2025

Hi @jerqi @zuston
We cannot install the native libs when running github action, can you help to solve it, thanks.
image

We can ignore them, let @zuston to check this.

This is caused by the unstable ubuntu background service, let's ignore this.

@jerqi
Copy link
Contributor

jerqi commented Feb 24, 2025

Hi @jerqi @zuston
We cannot install the native libs when running github action, can you help to solve it, thanks.
image

We can ignore them, let @zuston to check this.

This is caused by the unstable ubuntu background service, let's ignore this.

We can remove the module of Rust now.

@cchung100m
Copy link
Collaborator Author

Hi @jerqi

Do you mean this file?

https://github.com/apache/incubator-uniffle/blob/master/.github/workflows/rust.yml

We can remove the module of Rust now.

@cchung100m cchung100m marked this pull request as ready for review March 2, 2025 05:26
@cchung100m cchung100m requested a review from jerqi March 2, 2025 05:26
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi jerqi merged commit 413c852 into apache:master Mar 3, 2025
41 checks passed
@cchung100m cchung100m deleted the issue-2370 branch March 11, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Fix the warning: [unchecked] unchecked call to add(E) as a member of the raw type List

4 participants