-
Notifications
You must be signed in to change notification settings - Fork 170
[INFRA] Improve asf.yaml to reduce the notifications #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| issues: dev@uniffle.apache.org | ||
| pullrequests: notifications@uniffle.apache.org | ||
| commits: commits@uniffle.apache.org | ||
| issues: dev@uniffle.apache.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues will still go to dev@ to notify all the subscribers.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 56.29% 56.29%
Complexity 1168 1168
=========================================
Files 152 152
Lines 8401 8401
Branches 813 813
=========================================
Hits 4729 4729
Misses 3408 3408
Partials 264 264 Continue to review full report at Codecov.
|
colinmjj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What changes were proposed in this pull request? Fix the issues introduced in #25 to correct the notifications. ### Why are the changes needed? Reduce the PR comment noise in dev@. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A
What changes were proposed in this pull request?
Update the asf.yaml to reduce the PR notifications to dev@
Why are the changes needed?
Currently there're some many gitbox notifications to dev@, which is actually duplicated with GH notification itself, so trying to reduce this in dev@
Does this PR introduce any user-facing change?
No
How was this patch tested?
NA