Skip to content

Conversation

@jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Update the asf.yaml to reduce the PR notifications to dev@

Why are the changes needed?

Currently there're some many gitbox notifications to dev@, which is actually duplicated with GH notification itself, so trying to reduce this in dev@

Does this PR introduce any user-facing change?

No

How was this patch tested?

NA

@jerryshao jerryshao changed the title Improve asf.yaml to reduce the notifications [INFRA] Improve asf.yaml to reduce the notifications Jul 5, 2022
issues: dev@uniffle.apache.org
pullrequests: notifications@uniffle.apache.org
commits: commits@uniffle.apache.org
issues: dev@uniffle.apache.org
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues will still go to dev@ to notify all the subscribers.

@jerryshao jerryshao requested review from colinmjj and jerqi July 5, 2022 06:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #25 (103e31a) into master (8256765) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage     56.29%   56.29%           
  Complexity     1168     1168           
=========================================
  Files           152      152           
  Lines          8401     8401           
  Branches        813      813           
=========================================
  Hits           4729     4729           
  Misses         3408     3408           
  Partials        264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8256765...103e31a. Read the comment docs.

@jerryshao jerryshao added this to the ASF Podling milestone Jul 5, 2022
Copy link

@colinmjj colinmjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao jerryshao merged commit 0d7dfdb into apache:master Jul 5, 2022
jerqi pushed a commit that referenced this pull request Jul 5, 2022
### What changes were proposed in this pull request?

Fix the issues introduced in #25 to correct the notifications.

### Why are the changes needed?

Reduce the PR comment noise in dev@.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants