Skip to content

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 5, 2022

What changes were proposed in this pull request?

  1. Add BufferSegmentTest and PartitionRangeTest.
  2. Improve RemoteStorageInfoTest.

Why are the changes needed?

  1. A program with high test coverage has more of its source code executed during testing, which suggests it has a lower chance of containing undetected bugs.
  2. Demostrates how to improve test coverage with the help of Codecov.

Does this PR introduce any user-facing change?

No production code change.

How was this patch tested?

https://app.codecov.io/gh/kaijchen/incubator-uniffle/commit/cf7f30b1ee216bd6a36ba0eea37f14e7bc0ccbcb

@codecov-commenter
Copy link

Codecov Report

Merging #26 (cf7f30b) into master (8256765) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
- Coverage     56.29%   55.96%   -0.33%     
+ Complexity     1168     1132      -36     
============================================
  Files           152      143       -9     
  Lines          8401     8034     -367     
  Branches        813      784      -29     
============================================
- Hits           4729     4496     -233     
+ Misses         3408     3289     -119     
+ Partials        264      249      -15     
Impacted Files Coverage Δ
...er/impl/UploadedStorageHdfsShuffleReadHandler.java 76.31% <0.00%> (-5.27%) ⬇️
.../java/org/apache/uniffle/server/ShuffleServer.java 68.14% <0.00%> (-4.43%) ⬇️
...e/uniffle/server/storage/SingleStorageManager.java 65.57% <0.00%> (-1.64%) ⬇️
.../apache/uniffle/coordinator/ClientConfManager.java 91.54% <0.00%> (-1.41%) ⬇️
.../org/apache/spark/shuffle/writer/WriterBuffer.java
...k/shuffle/writer/WrappedByteArrayOutputStream.java
...ava/org/apache/spark/shuffle/RssShuffleHandle.java
...org/apache/spark/shuffle/RssSparkShuffleUtils.java
.../java/org/apache/spark/shuffle/RssSparkConfig.java
...org/apache/spark/shuffle/writer/AddBlockEvent.java
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8256765...cf7f30b. Read the comment docs.

@kaijchen
Copy link
Member Author

kaijchen commented Jul 5, 2022

Continue to review full report at Codecov.

The table posted by the bot is inaccurate, please see this link for details.

@jerqi jerqi changed the title [Test] Improve code coverage in rss-common [TEST] Improve code coverage in rss-common Jul 5, 2022
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit f7c9a2a into apache:master Jul 5, 2022
@kaijchen kaijchen deleted the improve-coverage branch July 5, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants