Skip to content

Conversation

@zuston
Copy link
Member

@zuston zuston commented Dec 24, 2025

What changes were proposed in this pull request?

Introduce the eager shuffle deletion mode to explicitly reduce the whole cluster shuffle storage capacity.

Why are the changes needed?

for the issue #2700

Does this PR introduce any user-facing change?

Yes. the option is introduced to enable this feature

spark.rss.client.eagerShuffleDeletion.enabled=false

How was this patch tested?

Unit tests

@zuston zuston marked this pull request as draft December 24, 2025 10:03
@github-actions
Copy link

github-actions bot commented Dec 24, 2025

Test Results

 3 193 files  +18   3 193 suites  +18   7h 5m 54s ⏱️ + 10m 25s
 1 243 tests + 5   1 242 ✅ + 5   1 💤 ±0  0 ❌ ±0 
15 737 runs  +48  15 722 ✅ +48  15 💤 ±0  0 ❌ ±0 

Results for commit d5399f7. ± Comparison against base commit 7867d59.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 68.51852% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.91%. Comparing base (7867d59) to head (448a69e).

Files with missing lines Patch % Lines
...niffle/shuffle/manager/StageDependencyTracker.java 74.41% 10 Missing and 1 partial ⚠️
...uniffle/shuffle/manager/RssShuffleManagerBase.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2704       +/-   ##
=============================================
+ Coverage          0   50.91%   +50.91%     
- Complexity        0     3271     +3271     
=============================================
  Files             0      533      +533     
  Lines             0    25526    +25526     
  Branches          0     2318     +2318     
=============================================
+ Hits              0    12996    +12996     
- Misses            0    11700    +11700     
- Partials          0      830      +830     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuston zuston marked this pull request as ready for review December 26, 2025 07:34
import org.apache.spark.scheduler.{SparkListener, SparkListenerStageCompleted, SparkListenerStageSubmitted}
import org.apache.uniffle.shuffle.manager.RssShuffleManagerBase

class UniffleStageDependencyListener extends SparkListener with Logging {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listener‘s event will be lost sometimes, especially there are huge events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants