[ISSUE-301][Subtask][Improvement][AQE] Merge continuous ShuffleDataSegment into single one#303
Merged
roryqi merged 1 commit intoapache:masterfrom Nov 7, 2022
Merged
Conversation
…gment into single one
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
============================================
+ Coverage 60.76% 60.79% +0.02%
- Complexity 1454 1457 +3
============================================
Files 179 179
Lines 9201 9207 +6
Branches 882 883 +1
============================================
+ Hits 5591 5597 +6
Misses 3316 3316
Partials 294 294
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
@jerqi PTAL |
roryqi
approved these changes
Nov 7, 2022
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Currently, the LocalOrderSegmentSplitter will split the index file into
multiple shuffleDataSegments. But the split scope is limited in the range of local order.
For example:
The blocks are as follow
When the reader want to get the range of taskIds: [1, 3), the strategy will return
two shuffleDataSegments. But we'd better to merge them into single one to
reduce the network interaction times, because they are continuous.
Does this PR introduce any user-facing change?
No
How was this patch tested?