Skip to content

Conversation

@leixm
Copy link
Contributor

@leixm leixm commented Nov 17, 2022

What changes were proposed in this pull request?

Fix wrong method name.

Why are the changes needed?

Fix wrong method name cause grpc_get_in_memory_shuffle_data_total always 0.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Already exists UT.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @leixm , wait for CI.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #335 (6bcbaf6) into master (9f0610a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage     61.09%   61.09%           
  Complexity     1509     1509           
=========================================
  Files           185      185           
  Lines          9410     9410           
  Branches        918      918           
=========================================
  Hits           5749     5749           
  Misses         3357     3357           
  Partials        304      304           
Impacted Files Coverage Δ
...pache/uniffle/server/ShuffleServerGrpcService.java 0.83% <ø> (ø)
...pache/uniffle/server/ShuffleServerGrpcMetrics.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit 60b68d8 into apache:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants