[ISSUE-364] Fix indexWriter don't close if exception thrown when close dataWriter#349
Merged
roryqi merged 1 commit intoapache:masterfrom Nov 22, 2022
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
============================================
+ Coverage 58.40% 58.42% +0.01%
Complexity 1554 1554
============================================
Files 193 193
Lines 10763 10758 -5
Branches 937 935 -2
============================================
- Hits 6286 6285 -1
+ Misses 4104 4102 -2
+ Partials 373 371 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Nov 22, 2022
Contributor
roryqi
left a comment
roryqi
left a comment
There was a problem hiding this comment.
LGTM, thanks @xianjingfeng
roryqi
pushed a commit
that referenced
this pull request
Nov 28, 2022
…ose dataWriter (#349) ### What changes were proposed in this pull request? Fix `indexWriter` don't close if exception thrown when close dataWriter ### Why are the changes needed? It's a bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? I think it's not necessary, because it's too simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
indexWriterdon't close if exception thrown when close dataWriterWhy are the changes needed?
It's a bug
Does this PR introduce any user-facing change?
No
How was this patch tested?
I think it's not necessary, because it's too simple.