Skip to content

Conversation

@roryqi
Copy link
Contributor

@roryqi roryqi commented Nov 23, 2022

What changes were proposed in this pull request?

https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AssigningexternalcollaboratorswiththetriageroleonGitHub
Projects may assign external (non-committer) collaborators the triage role for their repository.
The triage role allows people to assign, edit, and close issues and pull requests, without giving them write access to the code.

I add active contributors to the collaborators list.

Why are the changes needed?

It's convenient for the active contributors to manage issues.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

@roryqi roryqi requested a review from zuston November 23, 2022 06:42
@zuston
Copy link
Member

zuston commented Nov 23, 2022

Welcome @leixm @xianjingfeng @smallzhongfeng

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #351 (633bde6) into master (1aa3661) will decrease coverage by 2.95%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #351      +/-   ##
============================================
- Coverage     61.37%   58.42%   -2.96%     
- Complexity     1529     1554      +25     
============================================
  Files           186      193       +7     
  Lines          9445    10758    +1313     
  Branches        924      935      +11     
============================================
+ Hits           5797     6285     +488     
- Misses         3340     4102     +762     
- Partials        308      371      +63     
Impacted Files Coverage Δ
.../org/apache/uniffle/coordinator/AccessManager.java 94.28% <0.00%> (-5.72%) ⬇️
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 28.38% <0.00%> (-1.76%) ⬇️
...he/uniffle/coordinator/CoordinatorGrpcService.java 2.09% <0.00%> (-0.21%) ⬇️
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% <0.00%> (ø)
...ava/org/apache/uniffle/common/RssShuffleUtils.java
...bernetes/operator/pkg/controller/controller/rss.go 32.48% <0.00%> (ø)
...apache/uniffle/coordinator/AccessQuotaChecker.java 95.83% <0.00%> (ø)
...y/kubernetes/operator/pkg/webhook/inspector/pod.go 0.00% <0.00%> (ø)
deploy/kubernetes/operator/pkg/webhook/manager.go 53.43% <0.00%> (ø)
...y/kubernetes/operator/pkg/webhook/inspector/rss.go 47.70% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roryqi roryqi merged commit 72ef4e3 into apache:master Nov 23, 2022
@xianjingfeng
Copy link
Member

Thanks

@leixm
Copy link
Contributor

leixm commented Nov 23, 2022

Thanks.

@smallzhongfeng
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants