[ISSUE-228] Fix the problem of protobuf-java incorrect dependency at compile time #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
=========================================
Coverage 58.60% 58.60%
Complexity 1580 1580
=========================================
Files 194 194
Lines 10871 10871
Branches 956 956
=========================================
Hits 6371 6371
Misses 4126 4126
Partials 374 374 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tsface
changed the title
Contributor
|
Do you want to join our |
jerqi
pushed a commit
that referenced
this pull request
Nov 28, 2022
…compile time (#362) ### What changes were proposed in this pull request? 1. We specified the version number of `protobuf-java` in the `client-spark/spark3/pom.xml` file. ### Why are the changes needed? More reasonable. #228 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? We compiled in the test environment and verified the correctness of the `rss-client-spark3-0.6.0-shaded.jar` package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
protobuf-javain theclient-spark/spark3/pom.xmlfile.Why are the changes needed?
More reasonable. #228
Does this PR introduce any user-facing change?
No
How was this patch tested?
We compiled in the test environment and verified the correctness of the
rss-client-spark3-0.6.0-shaded.jarpackage.