[ISSUE-169] Support metric reporter and Support promethues push gateway#415
Merged
roryqi merged 10 commits intoapache:masterfrom Dec 21, 2022
Merged
[ISSUE-169] Support metric reporter and Support promethues push gateway#415roryqi merged 10 commits intoapache:masterfrom
roryqi merged 10 commits intoapache:masterfrom
Conversation
# Conflicts: # coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
xianjingfeng
changed the title
roryqi
reviewed
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
============================================
+ Coverage 58.54% 58.62% +0.08%
- Complexity 1611 1632 +21
============================================
Files 195 198 +3
Lines 11035 11130 +95
Branches 966 986 +20
============================================
+ Hits 6460 6525 +65
- Misses 4195 4218 +23
- Partials 380 387 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
reviewed
Dec 14, 2022
Contributor
|
Could we add some docs about this feature? |
Member
Author
Yes |
advancedxy
reviewed
Dec 16, 2022
common/src/main/java/org/apache/uniffle/common/metrics/MetricReporterFactory.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/metrics/MetricReporterFactory.java
Show resolved
Hide resolved
...n/java/org/apache/uniffle/common/metrics/prometheus/PrometheusPushGatewayMetricReporter.java
Show resolved
Hide resolved
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
Outdated
Show resolved
Hide resolved
3 tasks
Contributor
|
Is this pr ready for review? |
xianjingfeng
changed the title
Member
Author
Yes |
roryqi
approved these changes
Dec 21, 2022
Contributor
roryqi
left a comment
roryqi
left a comment
There was a problem hiding this comment.
LGTM, @advancedxy do you have another suggestion?
Contributor
|
thanks @advancedxy @xianjingfeng |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support metric reporter and Support promethues push gateway
Why are the changes needed?
Users can implement custom export plugin to export metrics to their monitoring system. #169
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT