[Chore]: document update and build time optimize #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building uniffle locally, I noticed that it requires JDK1.8 to build and suspicious maven-default-http-blocker for json-smart. ``` [WARNING] net.minidev:json-smart/maven-metadata.xmlfailed to transfer from http://0.0.0.0/ during a previous attempt. This failure was cached in the local repository and resolution will not be reattempted until the update interval of maven-default-http-blocker has elapsed or updates are forced. Original error: Could not transfer metadata net.minidev:json-smart/maven-metadata.xml from/to maven-default-http-blocker (http://0.0.0.0/): transfer failed for http://0.0.0.0/net/minidev/json-smart/maven-metadata.xml ``` To address these two issues, README.md is updated to reflect the requirement. The json-smart dependency is excluded from hadoop-common since it's never used. Before I'm making a PR, I found the project name in CONTRIBUTING.md is not changed yet. Thus, this commit also updates the CONTRIBUTING.md and makes some amend to the doc.
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
============================================
- Coverage 56.87% 56.83% -0.04%
+ Complexity 1207 1205 -2
============================================
Files 152 152
Lines 8429 8429
Branches 816 816
============================================
- Hits 4794 4791 -3
- Misses 3376 3377 +1
- Partials 259 261 +2
Continue to review full report at Codecov.
|
jerqi
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
When building uniffle locally, I noticed that it requires JDK1.8 to build and suspicious maven-default-http-blocker for json-smart.
Before I'm making a PR, I found the project name in CONTRIBUTING.md is not changed yet. Thus, this commit
also updates the CONTRIBUTING.md and makes some amend to the doc.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
No new tests are required.