Skip to content

Conversation

@zuston
Copy link
Member

@zuston zuston commented Jul 10, 2022

What changes were proposed in this pull request?

Supplement doc about assignment tags

Why are the changes needed?

Supplement doc about assignment tags

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

No need

@zuston
Copy link
Member Author

zuston commented Jul 10, 2022

@jerqi Add doc

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #47 (e3e2515) into master (ae674a6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
- Coverage     56.87%   56.86%   -0.02%     
+ Complexity     1207     1206       -1     
============================================
  Files           152      152              
  Lines          8429     8429              
  Branches        816      816              
============================================
- Hits           4794     4793       -1     
  Misses         3376     3376              
- Partials        259      260       +1     
Impacted Files Coverage Δ
.../apache/uniffle/coordinator/ClientConfManager.java 91.54% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae674a6...e3e2515. Read the comment docs.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 36bd95a into apache:master Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants