Skip to content

Conversation

@kaijchen
Copy link
Member

What changes were proposed in this pull request?

  1. Set indentation rules in checkstyle
  2. Fix violations.

Why are the changes needed?

#54

Does this PR introduce any user-facing change?

No.

How was this patch tested?

https://github.com/kaijchen/incubator-uniffle/runs/7351765430?check_suite_focus=true

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #56 (7086c41) into master (aa02ee6) will decrease coverage by 0.01%.
The diff coverage is 63.38%.

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
- Coverage     54.89%   54.88%   -0.02%     
- Complexity     1092     1093       +1     
============================================
  Files           146      146              
  Lines          7775     7775              
  Branches        749      749              
============================================
- Hits           4268     4267       -1     
- Misses         3270     3271       +1     
  Partials        237      237              
Impacted Files Coverage Δ
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java 32.50% <0.00%> (ø)
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java 0.00% <0.00%> (ø)
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% <ø> (ø)
.../org/apache/uniffle/common/config/ConfigUtils.java 22.36% <0.00%> (ø)
...rg/apache/uniffle/storage/common/LocalStorage.java 44.68% <0.00%> (ø)
...torage/handler/impl/ComposedClientReadHandler.java 0.00% <ø> (ø)
...e/uniffle/storage/handler/impl/HdfsFileWriter.java 55.22% <0.00%> (ø)
...e/storage/handler/impl/HdfsShuffleReadHandler.java 51.02% <0.00%> (ø)
...handler/impl/LocalFileQuorumClientReadHandler.java 0.00% <0.00%> (ø)
.../storage/handler/impl/MemoryClientReadHandler.java 0.00% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa02ee6...7086c41. Read the comment docs.

@jerqi
Copy link
Contributor

jerqi commented Jul 15, 2022

It's OK for me. And cc @colinmjj

Copy link

@colinmjj colinmjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@jerqi jerqi merged commit 55d64a9 into apache:master Jul 15, 2022
@kaijchen
Copy link
Member Author

Thanks @jerqi and @colinmjj for the review.

@kaijchen kaijchen deleted the indent branch July 15, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants