[Improvement] Log indicate the shuffle server host:port when doing re…#58
Merged
roryqi merged 1 commit intoapache:masterfrom Jul 16, 2022
Merged
[Improvement] Log indicate the shuffle server host:port when doing re…#58roryqi merged 1 commit intoapache:masterfrom
roryqi merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage 55.21% 55.21%
Complexity 1111 1111
=========================================
Files 148 148
Lines 7953 7953
Branches 760 760
=========================================
Hits 4391 4391
Misses 3321 3321
Partials 241 241 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Log indicate the shuffle server host:port when calling remote shuffle servers
Why are the changes needed?
Sometimes i want to look which shuffle server remote call cost the most time, but the current log can't help me find it.
If having this log, i will find slowest server and then to look its disk io metrics.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need