-
Notifications
You must be signed in to change notification settings - Fork 170
[#778] feat: Separate ShuffleServer metrics through tags
#812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ShuffleServer metrics through tags
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
============================================
+ Coverage 57.63% 58.83% +1.19%
- Complexity 2058 2068 +10
============================================
Files 306 292 -14
Lines 14871 13020 -1851
Branches 1221 1238 +17
============================================
- Hits 8571 7660 -911
+ Misses 5808 4922 -886
+ Partials 492 438 -54
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@smallzhongfeng Thanks for your work.. When I'm working on #793, I made similar changes. However it seems too much changes and it was primary to label cluster name and I thought it wasn't worth it. Do you have some more input for this one? I'm OK to accept this PR with some comments. |
|
Thanks @advancedxy , but currently, I'm sorry that I haven't found a better way to make the code more elegant.. :-( |
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java
Outdated
Show resolved
Hide resolved
af92fc0 to
e86ebad
Compare
common/src/main/java/org/apache/uniffle/common/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/util/Constants.java
Outdated
Show resolved
Hide resolved
|
If you have time, please help me take a look again. Thanks @advancedxy :-) |
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
advancedxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except one minor comment.
common/src/main/java/org/apache/uniffle/common/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
|
Also cc @jerqi ,thanks! |
|
Thanks! @advancedxy @jerqi Merged to master. |
hello,I am using spark on k8s + uniffle, want to monitor uniffle by promethus in grafana, can i add your WeChat or DingDing? |
|
Thank you for fast reply !!! |


What changes were proposed in this pull request?
Add

tagas label in the metrics.So that we can separate the metrics in Grafana.
Why are the changes needed?
Fix: #778
Does this PR introduce any user-facing change?
No.
How was this patch tested?
fix uts.