Skip to content

[Improvement] Shutdown the grpc executors pool when closing #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerqi merged 1 commit into from
Jul 26, 2022
Merged

[Improvement] Shutdown the grpc executors pool when closing #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/src/main/java/org/apache/uniffle/common/rpc/GrpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,13 @@ public class GrpcServer implements ServerInterface {

private final Server server;
private final int port;
private final ExecutorService pool;

public GrpcServer(RssBaseConf conf, BindableService service, GRPCMetrics grpcMetrics) {
this.port = conf.getInteger(RssBaseConf.RPC_SERVER_PORT);
long maxInboundMessageSize = conf.getLong(RssBaseConf.RPC_MESSAGE_MAX_SIZE);
int rpcExecutorSize = conf.getInteger(RssBaseConf.RPC_EXECUTOR_SIZE);
ExecutorService pool = new ThreadPoolExecutor(
pool = new ThreadPoolExecutor(
rpcExecutorSize,
rpcExecutorSize * 2,
10,
Expand Down Expand Up @@ -89,6 +90,9 @@ public void stop() throws InterruptedException {
server.shutdown().awaitTermination(10, TimeUnit.SECONDS);
LOG.info("GRPC server stopped!");
}
if (pool != null) {
pool.shutdown();
}
}

public void blockUntilShutdown() throws InterruptedException {
Expand Down