Skip to content

[Log Improvment] Add more detailed debug info for MR client #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerqi merged 1 commit into from
Jul 26, 2022
Merged

[Log Improvment] Add more detailed debug info for MR client #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions client-mr/src/main/java/org/apache/hadoop/mapreduce/task/reduce/RssEventFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,29 @@ public Roaring64NavigableMap fetchAllRssTaskIds() {
if (mapIndex < totalMapsCount) {
mapIndexBitmap.addLong(mapIndex);
} else {
LOG.error(taskAttemptID + " has overflowed mapIndex");
throw new IllegalStateException(errMsg);
}
} else {
LOG.warn(taskAttemptID + " is redundant on index: " + mapIndex);
}
} else {
LOG.warn(taskAttemptID + " is successful but cancelled by obsolete event");
}
}
// each map should have only one success attempt
if (mapIndexBitmap.getLongCardinality() != taskIdBitmap.getLongCardinality()) {
throw new IllegalStateException(errMsg);
}
if (tipFailedCount != 0) {
LOG.warn("There are " + tipFailedCount + " tipFailed tasks");
}
if (taskIdBitmap.getLongCardinality() + tipFailedCount != totalMapsCount) {
for (int index = 0; index < totalMapsCount; index++) {
if (!mapIndexBitmap.contains(index)) {
LOG.error("Fail to fetch " + " map task on index: " + index);
}
}
throw new IllegalStateException(errMsg);
}
return taskIdBitmap;
Expand Down