Introduce the asList method in ConfigOptions #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jerqi Could u help review? |
Contributor
|
Our RssConf imitate SparkConf's style. SparkConf don't have this function, too. Is it better to split config options on the outside of RssConf? |
Member
Author
|
I think it looks RssConf imitate FlinkConf's style. In Flink, it has asList method. |
jerqi
reviewed
Jul 2, 2022
common/src/main/java/com/tencent/rss/common/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
jerqi
reviewed
Jul 2, 2022
common/src/main/java/com/tencent/rss/common/config/RssConf.java
Outdated
Show resolved
Hide resolved
Contributor
OK. |
Member
Author
|
Updated. @jerqi |
jerqi
reviewed
Jul 3, 2022
common/src/main/java/com/tencent/rss/common/config/RssConf.java
Outdated
Show resolved
Hide resolved
jerqi
requested changes
Jul 3, 2022
common/src/test/java/com/tencent/rss/common/config/ConfigOptionTest.java
Outdated
Show resolved
Hide resolved
common/src/test/java/com/tencent/rss/common/config/ConfigOptionTest.java
Outdated
Show resolved
Hide resolved
jerqi
requested changes
Jul 3, 2022
common/src/main/java/com/tencent/rss/common/config/RssConf.java
Outdated
Show resolved
Hide resolved
jerqi
reviewed
Jul 3, 2022
common/src/main/java/com/tencent/rss/common/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
jerqi
approved these changes
Jul 3, 2022
Contributor
jerqi
left a comment
jerqi
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
jerqi
pushed a commit
that referenced
this pull request
Aug 5, 2022
### What changes were proposed in this pull request? Make the conf of rss.storage.basePath as list ### Why are the changes needed? Follow up the PR #9 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the asList method in ConfigOptions
Why are the changes needed?
It’s necessary when getting the list of values from the config directly.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT