-
Notifications
You must be signed in to change notification settings - Fork 168
[#881][0.7] fix(followup): Ensure LocalStorageMeta disk size is correctly updated when events are processed for 0.7.0 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@awdavidson Could you fix this issue? |
@jerqi please can you approve the workflow? |
|
@awdavidson What's your company? Do you have Wechat account? We have aWechat group. If you want to join the Wechat group, you can scan the QR code. |
Codecov Report
@@ Coverage Diff @@
## branch-0.7 #914 +/- ##
================================================
+ Coverage 60.75% 60.76% +0.01%
- Complexity 1795 1796 +1
================================================
Files 214 214
Lines 12383 12385 +2
Branches 1047 1048 +1
================================================
+ Hits 7523 7526 +3
+ Misses 4455 4454 -1
Partials 405 405
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @awdavidson , merged to branch 0.7.
I’ve been investigating in my personal time currently not related to employer. I do not have a WeChat, I’ll consider getting one. Thanks for merge 🙂 |
@awdavidson Thanks for your investigation. If you don't have Wechat, we usually use Chinese to communicate in the Wechat Group. we can also use English to communicate in the slack. |


What changes were proposed in this pull request?
Ensure all events are marked as understorage, this will result to the LocalStorageMeta being updated when events are processed.
Why are the changes needed?
Currently LocalStorageMeta is only update with metrics from the first event in a given shuffleId and partitionId, the first event updates metrics because there is no entry in partitionsOfStorage and the event get marked as underStorage, however, for future events in the same shuffleId and partitionId selectStorage returns the storage and does not mark the event as underStorage so when updateWriteMetrics is called, event.getUnderStorage() returns null and storage.updateWriteMetrics(metrics); is skipped.
As metrics are not updated correctly, LocalStorage.canWrite will not return the correct result.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit test which covers multi events for the same shuffleId and partitionId