[IMPROVEMENT][COMMON] Fix common module code style#99
Merged
roryqi merged 2 commits intoapache:masterfrom Jul 29, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
============================================
- Coverage 56.33% 56.31% -0.02%
+ Complexity 1176 1175 -1
============================================
Files 149 149
Lines 7992 7992
Branches 766 766
============================================
- Hits 4502 4501 -1
Misses 3246 3246
- Partials 244 245 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
roryqi
changed the title
frankliee
approved these changes
Jul 29, 2022
This was referenced Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To solve common module code style in pr Tencent/Firestorm#155
Why are the changes needed?
Improve our test code style
Does this PR introduce any user-facing change?
No
How was this patch tested?
I add the test code style check commits, common module passed.
https://github.com/jerqi/incubator-uniffle/runs/7572429851?check_suite_focus=true