DOM2SAX.parse(InputSource) should call DOM2SAX.parse() #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are required to compile Xalan sources. committing these files on 'master' as well
…er. this makes it little bit easier to view xalanj xslt transformation result. doing this xalanj codebase change on 'master' branch. the previous commit, did this codebase change on xalanj branch xalan-j_xslt3.0.
Comments in file.
Revert default indent-amount
…change that was done earlier : movement of the 2.7.3_release test cases to jira directory. also making a minor improvement to error handling within xalanj implementation codebase, when variables were not been resolved within an xslt 1.0 stylesheet.
committing minor changes to xalanj README file, as per the following change that was done earlier : movement of the 2.7.3_release test cases to jira directory. also making a minor improvement to error handling within xalanj implementation codebase, when variables were not been resolved within an xslt 1.0 stylesheet.
…alling `parse(Node)`, calls the `ContentHandler`'s `startDocument` and `endDocument`, since `parse()` won't call them in this case; `parse(InputSource unused)` just calls `parse(Node)`, so the `ContentHandler` does not gereceive the `startDocument` and `endDocument` events, which are mandated by the SAX specification. This can cause problems; see, for example, scala/scala-xml#694 The simplest way to fix this is to change `parse(InputSource unused)` to call `parse()` instead of `parse(Node)` - and this is what this pull request does.
|
Sorry for the delay in processing this. With all the changes made since then, the simplest and safest way to apply this seemed to be to cherry-pick the one file you altered rather than updating/reconciling/merging. I've done so. As I understand it, Git should have retained your credit on the change. Good catch, simple solution. Thanks! |
|
Thank you @jkesselm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DOM that is not a
Document,DOM2SAX.parse(), in addition to callingparse(Node), calls theContentHandler'sstartDocumentandendDocument, sinceparse()won't call them in this case;parse(InputSource unused)just callsparse(Node), so theContentHandlerdoes not gereceive thestartDocumentandendDocumentevents, which are mandated by the SAX specification.This can cause problems; see, for example, scala/scala-xml#694
The simplest way to fix this is to change
parse(InputSource unused)to callparse()instead ofparse(Node)- and this is what this pull request does.