Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1888] Allow allocations to be added to existing nodes #606

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Aug 2, 2023

What is this PR for?

Adds the ability to assign existing allocations dynamically to an already created node. This allows "late" events to be processed properly.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1888

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Aug 2, 2023
@craigcondit craigcondit force-pushed the YUNIKORN-1888 branch 2 times, most recently from ab89786 to cae509d Compare August 3, 2023 13:49
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #606 (5193285) into master (33cb12c) will decrease coverage by 0.29%.
The diff coverage is 2.22%.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   77.85%   77.56%   -0.29%     
==========================================
  Files          77       77              
  Lines       12933    12978      +45     
==========================================
- Hits        10069    10067       -2     
- Misses       2547     2593      +46     
- Partials      317      318       +1     
Files Changed Coverage Δ
pkg/scheduler/context.go 29.61% <0.00%> (-1.89%) ⬇️
pkg/scheduler/partition.go 77.83% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/scheduler/context.go Outdated Show resolved Hide resolved
pkg/scheduler/context.go Outdated Show resolved Hide resolved
Adds the ability to assign existing allocations dynamically to an
already created node. This allows "late" events to be processed
properly.
@craigcondit
Copy link
Contributor Author

Rebased PR on master after merging #615 and addressed review comments.

@craigcondit craigcondit requested a review from wilfred-s August 8, 2023 19:00
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in a4b2ebb Aug 16, 2023
@craigcondit craigcondit deleted the YUNIKORN-1888 branch August 16, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants