Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1929] fix update group configs #625

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

Keep a group tracker if it's from a specific limit to wildcard limit.

What type of PR is it?

  • - Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1929

How should this be tested?

Covered by unit tests.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #625 (0e20e7a) into master (96553dd) will increase coverage by 0.10%.
The diff coverage is 94.01%.

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   77.61%   77.71%   +0.10%     
==========================================
  Files          78       78              
  Lines       13044    12993      -51     
==========================================
- Hits        10124    10098      -26     
+ Misses       2593     2573      -20     
+ Partials      327      322       -5     
Files Changed Coverage Δ
pkg/scheduler/ugm/queue_tracker.go 93.06% <ø> (-0.05%) ⬇️
pkg/scheduler/ugm/manager.go 84.82% <87.50%> (+3.49%) ⬆️
pkg/scheduler/ugm/group_tracker.go 96.90% <100.00%> (+3.72%) ⬆️
pkg/scheduler/ugm/user_tracker.go 94.69% <100.00%> (+0.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Frank Yang <yangpoan@gmail.com>
@FrankYang0529
Copy link
Member Author

Close the PR since we only track a group which is defined in queue limit config.

@FrankYang0529 FrankYang0529 deleted the YUNIKORN-1929 branch September 1, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant