[YUNIKORN-2978] Fix handling of reserved allocations where node differs #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YUNIKORN-2700 introduced a bug where allocations of previously-reserved tasks were not handled correctly in the case where we schedule on a different node than the reservation. Ensure that we unreserve and allocate using the proper node in both cases. Also introduce additional logging of allocations on nodes to make finding issues like this easier in the future.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #996 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 97 97
Lines 15590 15620 +30
=======================================
+ Hits 12681 12706 +25
- Misses 2630 2634 +4
- Partials 279 280 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pbacsko
reviewed
Nov 17, 2024
wilfred-s
requested changes
Nov 18, 2024
I think the missing bit is just a single line: We need a unit tests, and it should be doable to create one:
Before the fix the allocation will show the reserved node ID or none at all. |
|
Addressed review comments. Reservation test updated to verify node assignment -- verified this test fails prior to this PR but passes now. |
craigcondit
added a commit
that referenced
this pull request
Nov 19, 2024
…rs (#996) YUNIKORN-2700 introduced a bug where allocations of previously-reserved tasks were not handled correctly in the case where we schedule on a different node than the reservation. Ensure that we unreserve and allocate using the proper node in both cases. Also introduce additional logging of allocations on nodes to make finding issues like this easier in the future. Closes: #996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
YUNIKORN-2700 introduced a bug where allocations of previously-reserved tasks were not handled correctly in the case where we schedule on a different node than the reservation. Ensure that we unreserve and allocate using the proper node in both cases.
Also introduce additional logging of allocations on nodes to make finding issues like this easier in the future.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2978
How should this be tested?
Verified successful processing of 1000-pod job on autoscaled cluster where previously this would fail.
Screenshots (if appropriate)
Questions: