Skip to content

Conversation

@yangwwei
Copy link
Contributor

@yangwwei yangwwei commented Aug 25, 2022

Docusaurus hides the version number in the URL for the latest versions, e.g right now our latest version is 1.0.0, but http://localhost:3000/docs/1.0.0 gives a 404. Ideally, we should make have an accessible URL for this version as well. This is in order to fix: apache/spark#37622

@yangwwei yangwwei self-assigned this Aug 25, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yangwwei !

@yangwwei yangwwei merged commit b745b72 into apache:master Aug 25, 2022
@yangwwei yangwwei deleted the YUNIKORN-1293 branch August 25, 2022 05:31
@wilfred-s
Copy link
Contributor

This is not a scalable or maintainable solution. It breaks the release procedure.

Not sure why YuniKorn needs to comply with this rule for a specific version of documentation when there is no version information in any of the volcano links published as part of the Spark 3.3 documentation:

@yangwwei
Copy link
Contributor Author

This is not a scalable or maintainable solution. It breaks the release procedure.

Not sure why YuniKorn needs to comply with this rule for a specific version of documentation when there is no version information in any of the volcano links published as part of the Spark 3.3 documentation:

This is a very good point. Let's move the discussion to the Spark community: apache/spark#37622. This PR is not a sustainable solution, it's gonna break when we release a new version. We can revert this once we reach a consensus there. BTW, I've spent hours and this is the best solution so far that can work.

@wilfred-s
Copy link
Contributor

We'll leave it in place for the next days, release 1.1 is due next week and should include a new versioned release for the docs to be created. Before we can commit that update this change will most likely need to be rolled back to not break our docs.

yangwwei added a commit to yangwwei/yunikorn-site that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants