Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2055] upgrade angular #139

Closed
wants to merge 3 commits into from

Conversation

wilfred-s
Copy link
Contributor

What is this PR for?

Upgrade angular to 16.2.10
typescript pinned to 5.1.6 and not ^5.1.6 as compile fails with 5.2.x

upgrade node.js to 18.18

What type of PR is it?

  • - Improvement

What is the Jira issue?

How should this be tested?

Manual testing of the generated web app

Upgrade angular to 16.2.10
typescript pinned to 5.1.6 and not ^5.1.6 as compile fails with 5.2.x

upgrade node.js to 18.18
@wilfred-s
Copy link
Contributor Author

:-( Karma update causes issues. The real failure is caused by this:

  An error was thrown in afterAll
  An asynchronous before/it/after function took a done callback but also returned a promise. Either remove the done callback (recommended) or change the function to not return a promise. thrown

There is no async calls that have a callback and promise that I can find...

@wilfred-s wilfred-s marked this pull request as draft October 20, 2023 04:56
cleanup imports and deprecated calls
@wilfred-s wilfred-s marked this pull request as ready for review October 27, 2023 01:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #139 (73ffd5c) into master (5fa48ad) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          30       30           
=======================================
  Hits           20       20           
  Misses          7        7           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@wilfred-s wilfred-s deleted the YUNIKORN-2055 branch November 8, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants