[YUNIKORN-2047] Remove duplicate colour in app state donut #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wilfred-s
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Only one comment: we should re-use the same colours as we use in #136 for some unity in the UI. The colours used in that PR are slightly different, choices can be made but I think limiting the colours is a good idea
List of colours used in the chart:
- '#4285f4'
- '#db4437'
- '#f4b400'
- '#0f9d58'
- '#ff6d00'
- '#3949ab'
- '#facc54'
- '#26bbf0'
- '#cc6164'
- '#60cea5'
|
With the addition of the bar chart for the node utilisation this PR will also need a rebase to resolve the conflicts |
|
Hi @wilfred-s thanks for your advice. I've updated the color code. Please take a look.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently, there are 11 states, but there are only 4 color codes in the donut graph. As a result, some states have the same color, which can be confusing at times. This PR adds more color codes to make it easier to distinguish between different states in the donut graph. The updated appearance is displayed below.
What type of PR is it?
Todos
What is the Jira issue?
YUNIKORN-2047
How should this be tested?
Screenshots (if appropriate)
Questions: