-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2342] Skeleton of the new UI #163
Conversation
cc @wilfred-s @craigcondit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3 ☔ View full report in Codecov by Sentry. |
To make it easy later on I think we should change the name of the component to something we can use in the long run. Also not sure if we want to use the
Last point: we probably should use the logo without the text below it. See https://github.com/apache/yunikorn-site/blob/master/static/img/logo/yunikorn_blue_logo.png for the small version. |
@wilfred-s Thanks for reviewing 👍 The new ui contains two part
My strategy involves prioritizing the development of the Visualizer component, which is why I focused solely on implementing it in the previous pull request. However, I believe it's beneficial to establish a framework for both components upfront. For the time being, Queue V2 will continue to utilize the V1 components. I plan to upgrade these to the new version once the Visualizer section is completed. |
I have a few concerns with the Visualizer page. The functionality is interesting, but it's not something that's immediately usable by most users -- the configmap contains a quoted yaml of the queues; there's really no context in which a bare queues.yaml file file is ever dealt with outside of this component. The visualizer feels more like a development tool rather than a usable UI for YuniKorn. If we want to keep it around for playing "what-if" with the design, that's fine, but then maybe it's best to simply make it a hidden URL and not put it in the side navigation bar. |
Thanks Craig for reviewing. I agree with all your points that the Visualizer page is mostly developer tool. I am okay with moving the Visualizer page to another URL after the beta phase, hidden from the menu tab. However, I think keeping the page during the beta phase has four great benefits:
Inspired by Dagster Imagine we hover over a specific queue on the leaf queue, and all other queues it can preempt will be highlighted on the page !
Imagine a user editing the YAML, and the visualizer visualizes what you edit instantly. |
We can't really do a functional WYSIWYG editor, as the UI doesn't integrate into the security model of Kubernetes (nor are there any plans to do so - that's a much larger conversation). Consequently the editor, if implemented, would always be half-functional. It simply does NOT belong in the UI as the UI is a user-oriented, not dev-oriented tool. Since we will likely never make this available as is, it should be hidden completely (not even a BETA link). Beta implies it will some day be stable. This will not. |
There may be a place for some sort of development tool or optional IDE plugin that could be used for this (though maintaining it could be burdensome). It just doesn't belong in the UI. |
@craigcondit, what do you think about using the URL |
Whatever URL is fine. I just think we shouldn't put it in the navigation bar and advertise it. |
Close this. Implement in #177 |
What is this PR for?
Skeleton of the new UI
What type of PR is it?
What is the Jira issue?
YUNIKORN-2342
Screenshots (if appropriate)