Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2339] Remove Nodes Utilisation chart from Dashboard page (Web) #164

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

@chenyulin0719 chenyulin0719 commented Feb 3, 2024

What is this PR for?

We have implemented multi-type resource utilisation chart in YUNIKORN-2325.
Remove the old node utilisation chart from Dashboard page, as its functionality is duplicated.

  1. Remove componenet app-node-utilization
  2. Remove componenet app-bar-char
  3. Remove all reference of deprecated api "ws/v1/scheduler/node-utilization"

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

NA

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2339

How should this be tested?

  • make lint
  • make license-check
  • yarn test:coverage
  • yarn start:srv
  • yarn start

Screenshots (if appropriate)

image

Questions:

NA

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cac541) 66.66% compared to head (68c2288) 66.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          30       30           
=======================================
  Hits           20       20           
  Misses          7        7           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chia7712
Copy link
Contributor

chia7712 commented Feb 3, 2024

@chenyulin0719 the link in description should be https://issues.apache.org/jira/browse/YUNIKORN-2339 rather than https://issues.apache.org/jira/browse/YUNIKORN-2325

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 closed this in e46c904 Feb 3, 2024
@chenyulin0719
Copy link
Contributor Author

@chenyulin0719 the link in description should be https://issues.apache.org/jira/browse/YUNIKORN-2339 rather than https://issues.apache.org/jira/browse/YUNIKORN-2325

Just updated, thanks for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants