[YUNIKORN-2679] Add copy URL button on the allocations panel #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented copy button on allocations sidebar view that copies the hot-link to that view.
- Added copy link test - Fixed linting in test file - Fixed errors on test suite execution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 2 2
Lines 49 49
=======================================
Hits 19 19
Misses 27 27
Partials 3 3 ☔ View full report in Codecov by Sentry. |
chenyulin0719
requested changes
Jun 24, 2024
There was a problem hiding this comment.
@dcoric , thanks for the new commit.
Please update the test function too, I saw some error logs after run 'pnpm test'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds a copy button to the allocations panel. It is using the hotlinking feature that was implemented with YUNIKORN-2624
What type of PR is it?
What is the Jira issue?
YUNIKORN-2679 Add copy URL button on the allocations panel
How should this be tested?
Open the allocations tab, in the title bar there should be a clipboard icon. Clicking that icon it should copy the URL to that view.
Screenshots (if appropriate)
Note
The test is added for the feature, and alongside that I have added a minor fix to the
licenses-modaltest file that was outputting some errors due to a missing import.