-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2861] - Angular upgrade to v18 #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built web image failed. Could you also change this PR title to the Jira name? So this PR could be linked to the corresponding Jira automatically.
Additional note: If the module federation PR goes through before this one, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 2 2
Lines 49 49
=======================================
Hits 19 19
Misses 27 27
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcoric The PR of module federation is merged. Rebased required, thanks!
- updated dependencies - added module federation plugin - fixed failing test - removed MatDrawer from declarations
a86a78f
to
96dbe43
Compare
Thanks. I have rebased and updated minor versions. The allocations drawer test reported that I have tested the changes by running the application in localhost, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked the web after running the commands below:
- make install
- make test
- make clean image
Also checked the web container running as expected.
What is this PR for?
This PR updates the Angular version to the v18. I have done it in 2 commits - to v17 and to v18. Small changes were required with the zone.js framework import.
The only condition is - a requirement for the minimum node version: v18.19.x
What type of PR is it?
Todos
What is the Jira issue?
YUNIKORN-2861 Angular upgrade to v18
How should this be tested?
I have executed the test suite and application build. Everything appears to be functional and correct.
Screenshots (if appropriate)
Questions: