Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2861] - Angular upgrade to v18 #203

Closed
wants to merge 5 commits into from

Conversation

dcoric
Copy link
Contributor

@dcoric dcoric commented Sep 9, 2024

What is this PR for?

This PR updates the Angular version to the v18. I have done it in 2 commits - to v17 and to v18. Small changes were required with the zone.js framework import.
The only condition is - a requirement for the minimum node version: v18.19.x

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

YUNIKORN-2861 Angular upgrade to v18

How should this be tested?

I have executed the test suite and application build. Everything appears to be functional and correct.

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built web image failed. Could you also change this PR title to the Jira name? So this PR could be linked to the corresponding Jira automatically.

.nvmrc Outdated Show resolved Hide resolved
@dcoric dcoric changed the title Yunikorn 2861 [YUNIKORN-2861] - Angular upgrade to v18 Sep 11, 2024
@dcoric
Copy link
Contributor Author

dcoric commented Sep 11, 2024

Additional note: If the module federation PR goes through before this one, @angular-architects/module-federation dependency needs to be updated to the 18.x version that matches the rest of the dependency structure.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.77%. Comparing base (048f46c) to head (96dbe43).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   38.77%   38.77%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           19       19           
  Misses         27       27           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcoric The PR of module federation is merged. Rebased required, thanks!

@dcoric
Copy link
Contributor Author

dcoric commented Sep 25, 2024

@dcoric The PR of module federation is merged. Rebased required, thanks!

Thanks. I have rebased and updated minor versions. The allocations drawer test reported that MatDrawer had to be removed from declarations in allocations-drawer.component.spec.ts. Doing that fixed the failing test.

I have tested the changes by running the application in localhost, make build and make test_js

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked the web after running the commands below:

  • make install
  • make test
  • make clean image

Also checked the web container running as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants