Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2609] Improve visual style of the Web UI #213

Closed
wants to merge 2 commits into from

Conversation

SP12893678
Copy link
Contributor

@SP12893678 SP12893678 commented Oct 20, 2024

What is this PR for?

Improve visual style of the Web UI
The full design can be previewed on this link: [ DESIGN ]

  • Fix padding/margin values
  • Add rounding on elements to match the design (menu selection, dropdowns, etc)
  • Fix font weight on visual elements to match the design

Detail:

  • Sidebar navigation UI
  • Header right top help button change icon
  • Global => Form Field (Input, Select) to be density
  • Dashboard page
    • Chart Card title & content => padding
    • Chart Card title => font size & font weight
    • Application Status & Container Status chart-legend => font weight
  • Applications page
    • Table header row => font weight
  • Nodes page
    • Table header row => font weight
    • indicator field => fix align & remove extra gap

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-2609

Screenshots (if appropriate)

Before After
bandicam.2024-10-20.14-36-52-828.mp4
bandicam.2024-10-20.14-38-30-685.mp4

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (f49e3f5) to head (67922a6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           20       20           
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenyulin0719 chenyulin0719 self-requested a review October 27, 2024 05:31
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Overall LGTM. Only one minor question.

src/app/components/nodes-view/nodes-view.component.html Outdated Show resolved Hide resolved
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@chenyulin0719
Copy link
Contributor

Hold this PR for a few days to see if @dcoric or @wilfred-s have capacity to double confirm.

@dcoric
Copy link
Contributor

dcoric commented Oct 28, 2024

+1 LGTM
I have tested it locally and it looks good.

@craigcondit
Copy link
Contributor

+1 LGTM I have tested it locally and it looks good.

Only committers should be adding +1/-1 to comments.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@SP12893678 SP12893678 deleted the YUNIKORN-2609 branch November 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants