-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2609] Improve visual style of the Web UI #213
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 35.71% 35.71%
=======================================
Files 2 2
Lines 56 56
=======================================
Hits 20 20
Misses 33 33
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. Overall LGTM. Only one minor question.
dd2558c
to
67922a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
Hold this PR for a few days to see if @dcoric or @wilfred-s have capacity to double confirm. |
+1 LGTM |
Only committers should be adding +1/-1 to comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
Improve visual style of the Web UI
The full design can be previewed on this link: [ DESIGN ]
Detail:
What type of PR is it?
What is the Jira issue?
YUNIKORN-2609
Screenshots (if appropriate)
bandicam.2024-10-20.14-36-52-828.mp4
bandicam.2024-10-20.14-38-30-685.mp4