Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2958] Display foreign allocations on the web UI #222

Closed
wants to merge 4 commits into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Nov 8, 2024

What is this PR for?

Display foreign allocations on the Nodes page.

Notes:

  1. The PR fetches both YK & non-YK allocations and combine them in a single list
  2. New "type" field is added
  3. An icon is rendered in a separate "type" column based on whether it's a Yunikorn or foreign pod.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2958

How should this be tested?

Screenshots (if appropriate)

view2 view1

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (d082b14) to head (ac3e66d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           20       20           
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things:

I don't think we want to show all the attributes unless we're in expanded view, otherwise this is going to get really ugly with lots of nodes. In fact, I'd opt to hide the attributes column entirely unless we're expanded. It's just not relevant 99% of the time.

I also don't think we should add a Kubernetes-specific icon (as at least in theory, the web UI is agnostic).

@pbacsko
Copy link
Contributor Author

pbacsko commented Nov 12, 2024

I decided not to use icons in the "Type" column. I've been unable to find a nice pair of arrow icons. Sometimes copyright is an issue because it's too prohibitive. I was thinking about calling it "Scheduled by Yunikorn", with a checkmark indicating a YK pod and an external link indicating a foreign pod, but ultimately it's just too much hassle. I've already spent hours on it.

Let's use a text field, this can be improved any time later on.

@pbacsko
Copy link
Contributor Author

pbacsko commented Nov 12, 2024

Rendered pages with the latest commit
foreign_text
yk_text

@pbacsko
Copy link
Contributor Author

pbacsko commented Nov 12, 2024

I don't think we want to show all the attributes unless we're in expanded view, otherwise this is going to get really ugly with lots of nodes. In fact, I'd opt to hide the attributes column entirely unless we're expanded. It's just not relevant 99% of the time.

Created https://issues.apache.org/jira/browse/YUNIKORN-2970. In my browser, it's displayed by default, but after clicking on "..." twice it disappears. This makes me think that it's supposed to be displayed only in enhanced mode.

@craigcondit
Copy link
Contributor

I think we should just remove the 'type' column. YuniKorn allocations can be easily discerned by the presence of the Application ID field.

@pbacsko
Copy link
Contributor Author

pbacsko commented Nov 12, 2024

I think we should just remove the 'type' column. YuniKorn allocations can be easily discerned by the presence of the Application ID field.

Makes sense. I'll catch up with Wilfred tomorrow morning. This would further simplify the changes.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants