-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2958] Display foreign allocations on the web UI #222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 35.71% 35.71%
=======================================
Files 2 2
Lines 56 56
=======================================
Hits 20 20
Misses 33 33
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things:
I don't think we want to show all the attributes unless we're in expanded view, otherwise this is going to get really ugly with lots of nodes. In fact, I'd opt to hide the attributes column entirely unless we're expanded. It's just not relevant 99% of the time.
I also don't think we should add a Kubernetes-specific icon (as at least in theory, the web UI is agnostic).
I decided not to use icons in the "Type" column. I've been unable to find a nice pair of arrow icons. Sometimes copyright is an issue because it's too prohibitive. I was thinking about calling it "Scheduled by Yunikorn", with a checkmark indicating a YK pod and an external link indicating a foreign pod, but ultimately it's just too much hassle. I've already spent hours on it. Let's use a text field, this can be improved any time later on. |
Created https://issues.apache.org/jira/browse/YUNIKORN-2970. In my browser, it's displayed by default, but after clicking on "..." twice it disappears. This makes me think that it's supposed to be displayed only in enhanced mode. |
I think we should just remove the 'type' column. YuniKorn allocations can be easily discerned by the presence of the Application ID field. |
Makes sense. I'll catch up with Wilfred tomorrow morning. This would further simplify the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
Display foreign allocations on the Nodes page.
Notes:
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2958
How should this be tested?
Screenshots (if appropriate)
Questions: