Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2961] Move node utilizations chart to dashboard page #224

Closed
wants to merge 3 commits into from

Conversation

SP12893678
Copy link
Contributor

@SP12893678 SP12893678 commented Nov 14, 2024

What is this PR for?

  • add a node utilization chart make the dashboard page more complete
  • add the partition selector in node utilization chart card
  • remove node utilizations chart in node view page

What type of PR is it?

  • - Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2961

Screenshots (if appropriate)

Before After Removed Max Width & Add maintainAspectRatio
bandicam.2024-11-14.23-02-44-261.mp4
bandicam.2024-11-14.23-07-50-521.mp4
bandicam.2024-11-15.20-55-51-284.mp4

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (d082b14) to head (360c775).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           20       20           
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just a couple points.

.app-node-utilizations {
::ng-deep .app-node-utilizations {
.card-wrapper {
max-width: 800px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have a max-width here. With lots of resource types, the extra horizontal real estate can be nice to have.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also means the chart should expand to fill the available space.

Copy link
Contributor Author

@SP12893678 SP12893678 Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I have removed the restrict, the updated demo shown as above.
The reason why I apend the restrict is consider the right side partition selector might be far for user.

Updated:
Oh, I find the chart maintainAspectRatio setting could address the issue.
It let chart fit the container.

@chenyulin0719 chenyulin0719 self-requested a review November 15, 2024 12:29
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants