[YUNIKORN-2993] Use empty array when stateLog not exists for AppInfo
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `stateLog` does not exist for some application returned by API `/ws/v1/partition/${partitionName}/queue/${queueName}/applications`, calling `appInfo.setLastStateChangeTime()` would trigger the following error:
```
TypeError: Cannot read properties of undefined (reading 'forEach')
at wne.setLastStateChangeTime (main.ec6040d2f2dbf6bb.js:1:775934)
```
We should fall back to empty array for `AppInfo.stateLog` when it doesn't exist in the API response.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 35.71% 35.71%
=======================================
Files 2 2
Lines 56 56
=======================================
Hits 20 20
Misses 33 33
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
Thanks! @craigcondit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
When
stateLogdoes not exist for some application returned by API/ws/v1/partition/${partitionName}/queue/${queueName}/applications, callingappInfo.setLastStateChangeTime()would trigger the following error:We should fall back to empty array for
AppInfo.stateLogwhen it doesn't exist in the API response.What type of PR is it?
Todos
What is the Jira issue?
YUNIKORN-2993
How should this be tested?
Manual
Screenshots (if appropriate)
Questions: