Skip to content

Commit

Permalink
[ZEPPELIN-6147] Make interpreter searching case-insensitive in new ui
Browse files Browse the repository at this point in the history
### What is this PR for?
The interpreter search in the new UI doesn’t ignore case sensitivity, unlike the old UI. I updated it to be case-insensitive in the new UI as well for better UX.

### What type of PR is it?
Improvement

### Todos

### What is the Jira issue?
[ZEPPELIN-6147](https://issues.apache.org/jira/browse/ZEPPELIN-6147/)

### How should this be tested?
* Ensure interpreters can be searched case-insensitively

### Screenshots (if appropriate)

**old ui**
<img src="https://github.com/user-attachments/assets/3096ed71-6e76-4dcb-b3db-ecac9d1ca2e6"  width="450" />

**new ui (before update)**
<img src="https://github.com/user-attachments/assets/371bdc9f-a0d2-47bd-b3c0-1786470758a9"  width="450" />


### Questions:
* Does the license files need to update?
* Is there breaking changes for older versions?
* Does this needs documentation?


Closes #4897 from seung-00/ZEPPELIN-6147.

Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
  • Loading branch information
seung-00 authored Nov 11, 2024
1 parent e463373 commit 97b12e6
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ export class InterpreterComponent implements OnInit, OnDestroy {
}

filterInterpreters(value: string) {
this.filteredInterpreterSettings = this.interpreterSettings.filter(e => e.name.search(value) !== -1);
this.filteredInterpreterSettings = this.interpreterSettings.filter(
e => e.name.search(new RegExp(value, 'i')) !== -1
);

this.cdr.markForCheck();
}

Expand Down

0 comments on commit 97b12e6

Please sign in to comment.