-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ZEPPELIN-6135] Fix clean goal not removing interpreter/ output(Spark…
…,Flink) ### What is this PR for? The Maven clean goal does not remove some interpreter files in `interpreter/` directory as expected. Specifically, the `spark` and `flink` interpreters are not cleaned. This happens because when extending the `pom.xml` in the `pom.xml` of these interpreters, they lack the `interpreter.name` property. As a result, the clean target directory configured in `zeppelion-interpreter-parent` was not properly resolved before. ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-6135 ### How should this be tested? - Build Zeppelin - Clean Zeppelin and check if all interpreters are removed in `interpreter/` ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4881 from tbonelee/fix-interparent-clean. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit f172b91) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
- Loading branch information
Showing
5 changed files
with
4 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters